Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource: aws_ssm_default_patch_baseline #27610

Merged
merged 15 commits into from
Nov 3, 2022
Merged

new resource: aws_ssm_default_patch_baseline #27610

merged 15 commits into from
Nov 3, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Nov 3, 2022 •
edited
Loading

Adds resource aws_ssm_default_patch_baseline

Relations

Closes #3342

References

Output from Acceptance Testing

$ make testacc PKG=ssm TESTS=TestAccSSM_

--- PASS: TestAccSSM_serial (290.21s)
    --- PASS: TestAccSSM_serial/DefaultPatchBaseline (273.37s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem (10.85s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/basic (43.16s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem (40.02s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/systemDefault (43.92s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/update (50.57s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/deleteDefault (20.50s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/multiRegion (30.92s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/disappears (14.35s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN (19.09s)
    --- PASS: TestAccSSM_serial/PatchBaseline (16.84s)
        --- PASS: TestAccSSM_serial/PatchBaseline/deleteDefault (16.84s)

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 3, 2022
ewbankkit
ewbankkit approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSM_serial' PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSM_serial -timeout 180m
go: downloading github.com/aws/aws-sdk-go-v2/service/ssm v1.31.3
=== RUN   TestAccSSM_serial
=== RUN   TestAccSSM_serial/DefaultPatchBaseline
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/systemDefault
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/update
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/disappears
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/deleteDefault
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/multiRegion
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/basic
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN
=== RUN   TestAccSSM_serial/PatchBaseline
=== RUN   TestAccSSM_serial/PatchBaseline/deleteDefault
--- PASS: TestAccSSM_serial (214.48s)
    --- PASS: TestAccSSM_serial/DefaultPatchBaseline (195.16s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/systemDefault (24.30s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/update (34.09s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem (8.26s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/disappears (16.28s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem (21.53s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/deleteDefault (20.17s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/multiRegion (28.23s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/basic (21.45s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN (20.84s)
    --- PASS: TestAccSSM_serial/PatchBaseline (19.31s)
        --- PASS: TestAccSSM_serial/PatchBaseline/deleteDefault (19.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	218.629s

@gdavison gdavison force-pushed the f-ssm-default-patch-baseline branch from ac40a4d to 460b1ad Compare November 3, 2022 17:32
@gdavison gdavison merged commit 6c1182c into main Nov 3, 2022
@gdavison gdavison deleted the f-ssm-default-patch-baseline branch November 3, 2022 18:03
@github-actions github-actions bot added this to the v4.38.0 milestone Nov 3, 2022
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
Update CHANGELOG.md for #27610
3cf15a2
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gdavison gdavison mentioned this pull request Nov 4, 2022
Merged
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.38.0
Development

Successfully merging this pull request may close these issues.

Add support for setting default SSM patch baseline
2 participants
@gdavison @ewbankkit